Browse Source

Avoid read channel corruption when response size > bufferSize

When receiving a response, what was happening

1. Read bufferSize and it gets assigned to leftdata
2. Read another bufferSize
3. 2 buffers get appended, but leftdata still points to first buffer
4. Process data buffer which contains only complete responses
5. Back to ReadLoop, but leftdata still points to first incomplete buffer
    causing corrupt data to be processed

Solution is to make leftdata nil once we have merged it with the second buffer
tags/0.2
Graham Barr 10 years ago
parent
commit
d82da8fd71
1 changed files with 1 additions and 0 deletions
  1. +1
    -0
      client/client.go

+ 1
- 0
client/client.go View File

@@ -104,6 +104,7 @@ ReadLoop:
}
if len(leftdata) > 0 { // some data left for processing
data = append(leftdata, data...)
leftdata = nil
}
for {
l := len(data)


Loading…
Cancel
Save