GaoreGo/goes
7
0
Fork 0
Code Pull Requests Releases 2 Activity

Merge pull request #18 from r--w/master

Browse Source 
Handling errors in bulk indexing.
This commit is contained in:
Jérôme Renard 2014-10-14 07:44:34 +02:00
commit 17253e07b0
3 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
goes.go
View File

@ -350,6 +350,17 @@ func (req *Request) Run() (Response, error) {
return Response{}, err return Response{}, err
} }
if req.api == "_bulk" && esResp.Errors {
for _, item := range esResp.Items {
for _, i := range item {
if i.Error != "" {
return Response{}, &SearchError{i.Error, i.Status}
}
}
}
return Response{}, &SearchError{Msg: "Unknown error while bulk indexing"}
}
if esResp.Error != "" { if esResp.Error != "" {
return Response{}, &SearchError{esResp.Error, esResp.Status} return Response{}, &SearchError{esResp.Error, esResp.Status}
} }

2
goes_test.go
View File

@ -227,6 +227,7 @@ func (s *GoesTestSuite) TestBulkSend(c *C) {
Type: docType, Type: docType,
Version: 1, Version: 1,
Index: indexName, Index: indexName,
Status: 201, //201 for indexing ( https://issues.apache.org/jira/browse/CONNECTORS-634 )
} }
c.Assert(response.Items[0][BULK_COMMAND_INDEX], Equals, i) c.Assert(response.Items[0][BULK_COMMAND_INDEX], Equals, i)
c.Assert(err, IsNil) c.Assert(err, IsNil)
@ -283,6 +284,7 @@ func (s *GoesTestSuite) TestBulkSend(c *C) {
Type: docType, Type: docType,
Version: 2, Version: 2,
Index: indexName, Index: indexName,
Status: 200, //200 for updates
} }
c.Assert(response.Items[0][BULK_COMMAND_DELETE], Equals, i) c.Assert(response.Items[0][BULK_COMMAND_DELETE], Equals, i)

3
structs.go
View File

@ -59,6 +59,7 @@ type Request struct {
type Response struct { type Response struct {
Acknowledged bool Acknowledged bool
Error string Error string
Errors bool
Status uint64 Status uint64
Took uint64 Took uint64
TimedOut bool `json:"timed_out"` TimedOut bool `json:"timed_out"`
@ -111,6 +112,8 @@ type Item struct {
Id string `json:"_id"` Id string `json:"_id"`
Index string `json:"_index"` Index string `json:"_index"`
Version int `json:"_version"` Version int `json:"_version"`
Error string `json:"error"`
Status uint64 `json:"status"`
} }
// Represents the "_all" field when calling the _stats API // Represents the "_all" field when calling the _stats API